Conversation
|
@BryonLewis the tests are fixed now. |
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Looks really good, thanks for doing this.
Just a few minor CSS/scrolling minor things and handling the case of a user pointing to an folder tree that has no valid datasets to import.
client/platform/desktop/frontend/components/BulkImportDialog.vue
Outdated
Show resolved
Hide resolved
Run imports sequentially, to prevent ffprobe from failing. ffprobe seems to fail if run with sufficiently many concurrent processes.
jjnesbitt
force-pushed
the
bulk-import
branch
from
8b4bb89 to
40ac579
Compare
| </v-card-title> | ||
| </v-card> | ||
| </v-dialog> | ||
| <v-dialog |
There was a problem hiding this comment.
@BryonLewis I split the current dialog into two separate dialogs, one for import / bulk data import, and the other for import status and the multicam dialog. I tested it locally and believe it works as expected, but I'm not too familiar with multicam stuff.
| :headers="headers" | ||
| show-select | ||
| disable-sort | ||
| @input="updateSelected" |
There was a problem hiding this comment.
Believe you still need to set some sort of max width on the data table:
DIVE-Bulk-Issue.mp4
There was a problem hiding this comment.
A specific max-width style wasn't necessary with the fix I implemented, but it still prevents overflow on all screen sizes (wraps text instead).
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing the wonkiness with the initial ffprobe checking for FPS. I think just the horizontal scrolling needs to be updated and this should be good.
2 participants
Closes #1455
Allows for bulk importing of datasets with a new "Bulk Import" button. This is done by recursively searching for datasets, wrapping the existing import sequence. If a directory fails the import sequence, the function will recurse into that directory.