Merged
Conversation
…on destination imports
…recursive dangling annotation processing
naglepuff
previously approved these changes
Sep 10, 2025
Collaborator
naglepuff
left a comment
There was a problem hiding this comment.
LGTM! From what I can tell this all works as intended. I found the test script to be very helpful and easy to use.
When I was looking at some of the scripts in VSCode the editor was complaining about a blank line missing.
Comment on lines
+94
to
+96
| minio_ip = get_container_ip(minio_container, "dive_default") | ||
| # Helper function: run mc inside persistent container | ||
| def mc_cmd(*args, capture_output=False): |
Collaborator
There was a problem hiding this comment.
Not a huge deal, but I think there should be a blank line somewhere in here. My editor was complaining
Collaborator
Author
There was a problem hiding this comment.
Yup my linter was yelling about this as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1505
Importing Logic:
Below is the logic as each file is imported (GirderItem) in this case:
Once all Items are imported a secondary process begins to kick off transcoding jobs. Injected into that is a new process to manage all dangling AnnotationFileFutureProcess files to place them in the proper folder.
Finally it kicks off process to import all video files as datasets by running the quick check to see if files need to be transcoded. During this process it calles the /postprocess endpoint that will check and look for CSV/JSON files in the same folder as the DIVEDataset and will import it as annotations if it exists.
Instructions for Testing are found in the ./samples/scripts/assetStoreImport/README.md file
Discussion of Technical Implementation:
DIVE-AssetStoreImport-TechnicalDetails_small.mp4
Testing Process:
DIVE-AssetStoreImport-Demo_small.mp4