Allow use of labels.txt file on desktop#1519
Conversation
|
Is it fully necessary to read the file contents in the client application and pass the text from the client to the back-end? I know that the previous templated data from a previous PR references to labelText as the direct text string. That may have been leftover from when we were considering training being a UI instead of a text file. It may be better to just pass the labelFile path location, opening it when initializing the training and using the file then instead of Reading it on the client and then creating a new file during execution. This would swap the front-end to use the async openFromDisk function to get the label file path and then pass that path to runTraining function where it will directly pass that to the VIAME training function instead of writing the file again. |
I don't think its fully necessary to read the file on the front end, but wouldn't we still need to rewrite the file to the pipeline directory? I initially considered an approach like this, but reading the text from the filing and passing that to the backend more closely matches what happens for the web version of the application, if that's not important here, and if you think passing the path makes more sense, I can revisit. |
That's a good point, leave it as is then. |
BryonLewis
left a comment
There was a problem hiding this comment.
Tested this version with training and some custom labels.txt and everything seemed to work well.
Fix #1511
Changes
This adds a new, optional field to the training form on the desktop application where users can attach a

labels.txtfile to their training run.This file's contents are passed as text to the IPC call that spawns a training job. The contents are written as
labels.txtin the pipeline folder and passed as an argument to the VIAME training call.