Merged
Conversation
Merged
naglepuff
approved these changes
Oct 7, 2025
Collaborator
naglepuff
left a comment
There was a problem hiding this comment.
LGTM! Code all makes sense to me and it works locally.
One thought is that I was wondering if it would be possible to move all of the SVG/css filter code into its own component that could be imported and used by each Annotator component, instead of repeating across the annotators.
Not really a dealbreaker for me here, but perhaps a follow up to this work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves part of #1510
A Subsquent PR is going to hook this data into the saving system where it will be saved similar to the confidence threshold. This would allow anyone to adjust the image settings and have it persist so others see the same thing.
DIVE-20250918-ImageEnhancementsPR_small.mp4