Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data sampling
Sampling works on local file/ local directory / URL.
We start by estimating the original size and check if it is above the
SAMPLING_SIZE_THRESHOLDIf so, we default to sampling, but the user can override and decide to not perform sampling.
In case of a directory, there may be 2 scenarios - either you have a directory wth a small number of files that are sizeable, and hence needs to be sampled at an individual file level. Or you have a directory with a large number of small files - in which case it'd be more sensible to just pick a subset of files as the sample. Both these cases are handled based on
SAMPLING_FILE_SIZE_THRESHOLD.So, we check the average file size, and if it's >
SAMPLING_FILE_SIZE_THRESHOLD, then we peform file-level-sampling - meaning, we sample each file in the directory individually.On the other hand if avg file size < =
SAMPLING_FILE_SIZE_THRESHOLD, then we perform directory-level-sampling - meaning, we choose a subset of files in the directory as the sample set. If an individual chosen file exceeds threshold, we sample it individually as well.