Skip to content

feat(display): Configure display device based on user config#3441

Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
FrogTheFrog:libdd-part-2
Jan 8, 2025
Merged

feat(display): Configure display device based on user config#3441
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
FrogTheFrog:libdd-part-2

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Dec 11, 2024

Description

This is a part 2 of #2894.

This PR adds support for configuring display via the display device library from the previous commit.
This is completely optional feature, which can be disabled with a single config switch.

This includes:

  • Changing display modes based on what the client requests or hardcoding some values.
  • Toggling HDR state.
  • Activating/deactivating displays.
  • Persistently restoring original settings in case Sunshine crashes or something similar happens.

The changes are best understood from screenshots below.

Screenshot

New advanced settings panel:
image

Device config options:
image

Resolution drop-down 1:
image

Resolution drop-down 2:
image

Refresh rate drop-down 1:
image

Refresh rate drop-down 2:
image

HDR drop-down:
image

The "hard reset" option in case the previous display config can no longer be restored (display no longer available/firmware was updated so the device id has changed/etc.):
image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants