Also like to use NetStandard for projects that doesn't need API-specific-code. But usually the application-project has to decide on the framework (net8 / net462 / etc), and the NLog configuration setup is only required for the application-project. Thus there should be no issue.

But if you really insist on having NetStandard-support for AtomicFile-package, then I prefer that it is done by using the Windows-API directly instead of using the System.IO.FileSystem.AccessControl-nuget-package.

https://github.com/NLog/NLog/blob/f90a55e943c9b1457349225f7350d1cd6065010b/src/NLog/Internal/Win32FileNativeMethods.cs

            int fileShare = Win32FileNativeMethods.FILE_SHARE_READ;

            if (allowFileSharedWriting)
            {
                fileShare |= Win32FileNativeMethods.FILE_SHARE_WRITE;
            }

            if (this.CreateFileParameters.EnableFileDelete)
            {
                fileShare |= Win32FileNativeMethods.FILE_SHARE_DELETE;
            }

            Microsoft.Win32.SafeHandles.SafeFileHandle handle = null;
            FileStream fileStream = null;

            try
            {
                handle = Win32FileNativeMethods.CreateFile(
                fileName,
                Win32FileNativeMethods.FileAccess.GenericWrite,
                fileShare,
                IntPtr.Zero,
                Win32FileNativeMethods.CreationDisposition.OpenAlways,
                this.CreateFileParameters.FileAttributes,
                IntPtr.Zero);

                if (handle.IsInvalid)
                {
                    Marshal.ThrowExceptionForHR(Marshal.GetHRForLastWin32Error());
                }

                fileStream = new FileStream(handle, FileAccess.Write, this.CreateFileParameters.BufferSize);
                return fileStream;
            }
            catch
            {
                if ((handle != null) && (!handle.IsClosed))
                    handle.Close();
                throw;
            }

The code above needs to be adjusted to provide the input-parameters (FILE_APPEND_DATA | SYNCHRONIZE) for atomic-append. Ensure to provide a FileStream-BufferSize of only 1.

I guess you can verify your implementation by temporarily removing "net8.0" from target-frameworks, so the unit-test will exercise your new the NetStandard-implementation:

Add .NET Standard 2.0 support to AtomicFile package #6098

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions