FileTarget - Closing on OpenFileCacheTimeout apply least recently used#5948
Merged
FileTarget - Closing on OpenFileCacheTimeout apply least recently used#5948
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant FileTarget
participant IFileAppender
participant MinimalFileLockingAppender
participant ExclusiveFileLockingAppender
participant DiscardAllFileAppender
FileTarget->>IFileAppender: Access LastWriteTime
IFileAppender-->>FileTarget: Return last write timestamp
MinimalFileLockingAppender->>MinimalFileLockingAppender: On Write()
MinimalFileLockingAppender->>MinimalFileLockingAppender: Update LastWriteTime
FileTarget->>FileTarget: PruneOpenFileCacheUsingTimeout()
FileTarget->>IFileAppender: Use LastWriteTime to determine stale files
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
snakefoot
changed the title
snakefoot
force-pushed
the
least_recently_used
branch
from
60d6d90 to
c29d69b
Compare
snakefoot
changed the title
snakefoot
force-pushed
the
least_recently_used
branch
from
c29d69b to
d018d7f
Compare
snakefoot
changed the title
snakefoot
changed the title
|
This was referenced Aug 13, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert to same behavior as NLog v5 FileTarget: