src/NLog/Targets/FileArchiveHandlers/RollingArchiveFileHandler.cs (1)

130-134: Align wildcard index semantics with Base handler and avoid path-level Replace.

For consistency with BaseFileArchiveHandler (single '' strictness) and to avoid accidental Replace in directory segments, compute indices from the file name and use LastIndexOf('').

-                var archivePathWildCard = _fileTarget.BuildFullFilePath(newFilePath, int.MaxValue, DateTime.MinValue).Replace(int.MaxValue.ToString(), "*");
-                var archiveFileName = Path.GetFileName(archivePathWildCard);
-                var fileWildcardStartIndex = archiveFileName.IndexOf('*');
-                var fileWildcardEndIndex = fileWildcardStartIndex >= 0 ? archiveFileName.Length - fileWildcardStartIndex : -1;
+                var archiveTestPath = _fileTarget.BuildFullFilePath(newFilePath, int.MaxValue, DateTime.MinValue);
+                var archiveFileName = Path.GetFileName(archiveTestPath).Replace(int.MaxValue.ToString(), "*");
+                var fileWildcardStartIndex = archiveFileName.IndexOf('*');
+                var lastStarIndex = archiveFileName.LastIndexOf('*');
+                var fileWildcardEndIndex = (fileWildcardStartIndex >= 0 && fileWildcardStartIndex == lastStarIndex)
+                    ? archiveFileName.Length - fileWildcardStartIndex
+                    : -1;

src/NLog/Targets/FileArchiveHandlers/BaseFileArchiveHandler.cs (1)

94-96: Single-wildcard strictness: good guard, consider centralizing helper.

This matches the “strict only with single '*'” intent. To keep semantics consistent across callers (e.g., RollingArchiveFileHandler), consider extracting a small helper to compute (startIndex, endIndex) to avoid divergence.

Example helper (internal):

internal static (int Start, int End) ComputeSingleStarIndices(string pattern)
{
    var s = pattern.IndexOf('*');
    return (s >= 0 && s == pattern.LastIndexOf('*'))
        ? (s, pattern.Length - s)
        : (s, -1);
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.