Extract NLog extensions to their own repository by snakefoot · Pull Request #5985 · NLog/NLog

snakefoot · 2025-09-03T18:54:26Z

36917 source-code-lines moved.

Created: https://github.com/NLog/NLog.WindowsRegistry

Created: https://github.com/NLog/NLog.Targets.Trace

Created: https://github.com/NLog/NLog.Targets.ConcurrentFile

Created: https://github.com/NLog/NLog.Targets.Database

Created: https://github.com/NLog/NLog.Targets.Mail

Created: https://github.com/NLog/NLog.Targets.WebService

Created: https://github.com/NLog/NLog.Targets.Network

Working towards completing #4952

coderabbitai · 2025-09-03T18:54:36Z

Walkthrough

Removed four legacy target projects (NLog.Database, NLog.Targets.ConcurrentFile, NLog.Targets.Mail, NLog.Targets.Network) and their project files, code, layouts, internal helpers, enums, and docs; updated build and test scripts to stop packaging and running tests for the removed components.

Changes

Cohort / File(s)	Summary
Build & Test scripts `build.ps1`, `run-tests.ps1`, `appveyor.yml`	Removed packaging and test invocations for Database, Mail, Network, Trace, WebService, ConcurrentFile targets; removed MSSQL2019 init step in CI matrix. Remaining build flow and other packages/tests unchanged.
NLog.Database (entire project removed) `src/NLog.Database/...` `src/NLog.Database/NLog.Database.csproj`, `src/NLog.Database/DatabaseTarget.cs`, `src/NLog.Database/DatabaseCommandInfo.cs`, `src/NLog.Database/DatabaseParameterInfo.cs`, `src/NLog.Database/DatabaseObjectPropertyInfo.cs`, `src/NLog.Database/Internal/*`, `src/NLog.Database/Properties/AssemblyInfo.cs`, `src/NLog.Database/README.md`	Deleted the Database target project, its DatabaseTarget and related public types, internal helpers, project/assembly metadata, and README.
NLog.Targets.ConcurrentFile (entire project removed) `src/NLog.Targets.ConcurrentFile/...` `src/NLog.Targets.ConcurrentFile/NLog.Targets.ConcurrentFile.csproj`, `src/NLog.Targets.ConcurrentFile/FileAppenders/`, `.../FileArchiveModes/`, `.../Internal/*`, `ArchiveNumberingMode.cs`, `FileArchiveEveryPeriod.cs`, `FilePathKind.cs`, `IFileCompressor.cs`, `IArchiveFileCompressor.cs`, `Win32FileAttributes.cs`, `Properties/AssemblyInfo.cs`, `README.md`	Removed the legacy ConcurrentFile target, all appender implementations (single/multi-process, mutex, unix/windows), archive mode implementations, internal utilities (watchers, helpers, recyclers), interfaces/enums, project/assembly files, and docs.
NLog.Targets.Mail (entire project removed) `src/NLog.Targets.Mail/...` `src/NLog.Targets.Mail/NLog.Targets.Mail.csproj`, `MailTarget.cs`, `ISmtpClient.cs`, `MySmtpClient.cs`, `SmtpAuthenticationMode.cs`, `Properties/AssemblyInfo.cs`, `README.md`	Deleted Mail target, SMTP abstractions/wrapper, authentication enum, project/assembly metadata, and README.
NLog.Targets.Network (entire project removed) `src/NLog.Targets.Network/...` `src/NLog.Targets.Network/NLog.Targets.Network.csproj`, `Targets/`, `Layouts/`, `NetworkSenders/`, `Internal/`, `Properties/AssemblyInfo.cs`, `README.md`	Removed NetworkTarget and derivatives (Gelf/Splunk/Log4JXml targets), related layouts (GelfLayout, SyslogLayout/ enums, Log4JXmlEventLayout, SplunkLayout), network sender stack (TCP/UDP/HTTP, SSL proxies), factories/interfaces, internal helpers, public enums/event args, project/assembly files, and docs.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120+ minutes

Poem

I trimmed my garden of wires and wheels,
Packed up the nets, the mails, the deals.
Soft paws sweep targets from the lane,
Lighter hops across the plain.
Logs still thump—thump—clear and bright;
Fewer burrows, faster flight.
(_/)> 🧹✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-09-03T19:14:05Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

snakefoot · 2025-09-03T19:33:46Z

Azure DevOps build-time dropped from 10mins to 7mins.

The builds should also become more stable since no dependency on SQL-server and network-communication.

snakefoot added this to the 6.0 milestone Sep 3, 2025

snakefoot added the build-config label Sep 3, 2025

pull-request-size bot added the size/XXL label Sep 3, 2025

Extract NLog extensions to their own repository

57e950c

snakefoot force-pushed the extract_ex branch from 6beba8c to 57e950c Compare September 3, 2025 19:06

snakefoot merged commit 55eaacb into NLog:dev Sep 4, 2025
6 checks passed

snakefoot mentioned this pull request Sep 4, 2025

Extract NLog extensions to their own repository #4952

Closed

13 tasks

coderabbitai bot mentioned this pull request Sep 7, 2025

Version 6.0.4 #5995

Merged

snakefoot mentioned this pull request Sep 28, 2025

New NLog extensions with NLog v6 #6003

Merged

jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025

Removes database and mail targets due to NLog/NLog#5985.

435b02a

jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025

Removes database and mail targets due to NLog/NLog#5985.

07cfa62

jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025

Removes database and mail targets due to NLog/NLog#5985.

71b52b3

jcasale added a commit to jcasale/PSNLog that referenced this pull request Dec 17, 2025

Removes database and mail targets due to NLog/NLog#5985.

7d529f8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract NLog extensions to their own repository#5985

Extract NLog extensions to their own repository#5985
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:extract_ex

snakefoot commented Sep 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Uh oh!

snakefoot commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

snakefoot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Quality Gate passed

Uh oh!

snakefoot commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

snakefoot commented Sep 3, 2025 •

edited

Loading

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)