Walkthrough

Reworks internal XML parsing in XmlParser.cs: localizes current-char handling, tightens Unicode/hex/token/name validation, standardizes error messages with line info, streamlines attributes/CDATA/processing-instruction parsing, and replaces some index-based loops with foreach — no public API changes.

Changes

Sequence Diagram(s)

sequenceDiagram
  participant Loader as Parser.LoadDocument
  participant Src as _xmlSource
  participant P as XmlParser

  rect `#f3f7ff`
    Loader->>P: Start parsing
    P->>Src: MoveNext / Peek (read chars)
    alt Start element
      P->>P: TryReadStartElement()
      P->>P: TryReadName() — local `chr` loop
      P->>P: _ = TryReadAttributes()
    end
    alt Unicode/Hex sequence
      P->>P: TryParseUnicodeValue / TryParseUnicodeValueHex()
      note right of P `#e9f9ee`: local char, explicit digit/hex checks\nenforce max Unicode
    end
    alt End-tag / token validation
      P->>P: foreach char → validate (no index arithmetic)
    end
    P->>Loader: Return parsed document or throw (errors include line info)
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Check Unicode/hex boundary checks and max-value enforcement.
• Verify foreach end-tag/token loops preserve previous edge-case semantics.
• Confirm error-message formatting includes correct line numbers and context.
• Ensure _ = TryReadAttributes(...) usage doesn't hide needed return-value handling.

Poem

🐰 I hopped through tags both wide and narrow,
Local chars kept snug and bright,
Hexes checked beneath my paw,
Tokens tidy, errors right,
I nibble bugs and dance at night. 🥕

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud