Skip to content

Marked ConversionHelpers.TryParseEnum as obsolete#6076

Merged
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:TryParseEnum
Jan 31, 2026
Merged

Marked ConversionHelpers.TryParseEnum as obsolete#6076
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:TryParseEnum

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 17, 2026 •
edited
Loading

Resolves #5893

@snakefoot snakefoot added the breaking change Breaking API change (different to semantic change) label Jan 17, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026 •
edited
Loading

Warning

Rate limit exceeded

@snakefoot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between be28e5b and 8b9e1e4.

📒 Files selected for processing (3)
  • src/NLog/Common/ConversionHelpers.cs
  • src/NLog/Config/LoggingConfigurationParser.cs
  • tests/NLog.UnitTests/Internal/ConversionHelpersTests.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 17, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@snakefoot snakefoot merged commit 5d28181 into NLog:dev Jan 31, 2026
5 of 6 checks passed
@snakefoot snakefoot added this to the 6.1.0 milestone Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change Breaking API change (different to semantic change) size/M

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

Mark TryParseEnum from ConversionHelpers as obsolete

1 participant

@snakefoot