Fix alpine Makefile "panic" subst on MacOS#113
Closed
kflu wants to merge 10000 commits intoNetBSD:trunkfrom
Closed
Fix alpine Makefile "panic" subst on MacOS#113kflu wants to merge 10000 commits intoNetBSD:trunkfrom
kflu wants to merge 10000 commits intoNetBSD:trunkfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alpine's Makefile has source string substitution for
panic(toPanic(. However, both the file name search pattern and the replacement string search pattern is no longer complete, causing somealpine_panic()to still exist, while the definition has changed toalpine_Panic().This change fixes that.