Fix use of newer Bouncycastle library#1065
Closed
raymens wants to merge 4 commits intoNethereum:masterfrom
Closed
Conversation
Member
|
Fixed another way. Many thanks. It is in 5.0.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation contained an issue, that might actually be part of Bouncycastle itself.
The
Closemethod that was being called on the legacy versions was no longer part of theDerSequenceGeneratorin the newer version.After some additional digging it seems to have been replaced by a
Finishmethod, however that method has theprotectedaccessibility modifier and it thus not available by default.To fix that I introduced a
CompatibleDerSequenceGeneratorclass that doesn't do much except for adding back theClosemethod and calling on the protectedFinishin case of the newer version.To make sure this Invalid DER Signature exception was tested I've added additional frameworks to the Nethereum.Signer.Unittests project.