Allow to do gemv and ger buffer allocation on the stack#482
Merged
xianyi merged 1 commit intoOpenMathLib:developfrom Jan 1, 2015
Merged
Allow to do gemv and ger buffer allocation on the stack#482xianyi merged 1 commit intoOpenMathLib:developfrom
xianyi merged 1 commit intoOpenMathLib:developfrom
Conversation
ger and gemv call blas_memory_alloc/free which in their turn call blas_lock. blas_lock create thread contention when matrices are small and the number of thread is high enough. We avoid call blas_memory_alloc by replacing it with stack allocation. This can be enabled with: make -DMAX_STACK_ALLOC=2048 The given size (in byte) must be high enough to avoid thread contention and small enough to avoid stack overflow. Fix OpenMathLib#478
xianyi
added a commit
that referenced
this pull request
Jan 1, 2015
Allow to do gemv and ger buffer allocation on the stack
xianyi
added a commit
that referenced
this pull request
Apr 13, 2015
xianyi
added a commit
that referenced
this pull request
Apr 13, 2015
jeromerobert
added a commit
to jeromerobert/OpenBLAS
that referenced
this pull request
Apr 15, 2015
jeromerobert
added a commit
to jeromerobert/OpenBLAS
that referenced
this pull request
Apr 15, 2015
xianyi
added a commit
that referenced
this pull request
Apr 20, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ger and gemv call blas_memory_alloc/free which in their turn
call blas_lock. blas_lock create thread contention when matrices
are small and the number of thread is high enough. We avoid
call blas_memory_alloc by replacing it with stack allocation.
This can be enabled with:
make -DMAX_STACK_ALLOC=2048
The given size (in byte) must be high enough to avoid thread contention
and small enough to avoid stack overflow.
Fix #478