Merged
Conversation
adriengivry
added
QoL
litelawliet
reviewed
Oct 5, 2020
litelawliet
reviewed
Oct 5, 2020
litelawliet
reviewed
Oct 5, 2020
litelawliet
reviewed
Oct 5, 2020
Contributor
litelawliet
left a comment
litelawliet
left a comment
There was a problem hiding this comment.
My comments mainly concerns readability since auto alone is mature enough to adapt itself to a pointer or reference. I think it is more readable to keep the *, also my comments doesn't change the bahaviour, const auto in this context is an auto* const but it just hides the true type (pointers here)
Member
Author
|
@litelawliet I disagree about specifying the asterisk with |
The actor creation menu had duplicated code. It actually was implemented twice (In `MenuBar` and `Hierarchy`). To avoid that, an `OvEditor/Utils/` folder has been added with an `ActorCreationMenu` class. This class exposes a function that generates an actor creation menu. It is now also possible to create a new actor by right-clicking onto the `Root` node in the hierarchy.
adriengivry
force-pushed
the
feature/improved_actor_creation_menu
branch
from
fa25b68 to
2c1a022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actor creation menu had duplicated code. It actually was implemented twice (In
MenuBarandHierarchy). To avoid that, anOvEditor/Utils/folder has been added with anActorCreationMenuclass. This class exposes a function that generates an actor creation menu.It is now also possible to create a new actor by right-clicking onto the
Rootnode in the hierarchy.This PR also changes the default name of created actors.
Previously, creating an actor resulted in an actor named "New Actor".
Now, the name of the created actor depends on its type (Camera, Cube, Sphere, Physical Box...)