Merged
Conversation
adriengivry
force-pushed
the
feature/post_process
branch
from
93cb472 to
3798451
Compare
adriengivry
changed the title
adriengivry
requested review from
BenjaminViranin,
litelawliet and
maxbrundev
adriengivry
force-pushed
the
feature/post_process
branch
from
7a63136 to
cfefb31
Compare
2 tasks
adriengivry
changed the title
adriengivry
changed the title
adriengivry
force-pushed
the
feature/post_process
branch
from
95090f7 to
f702fc8
Compare
adriengivry
force-pushed
the
feature/post_process
branch
from
0012506 to
e46d909
Compare
* Added PostProcessStack to manage effect settings * Separated effects into different classes * Updated Lua bindings * Added Blit method to the base renderer
…e grid can be drawn properly, excluding already rendered pixels
* fixed framebuffer wasn't properly set to HDR after resize * removed built-in tonemapping + gamma correction in PBR shader (since it's already performed as a post-processing effect)
adriengivry
force-pushed
the
feature/post_process
branch
from
826140f to
34b9867
Compare
adriengivry
commented
Feb 7, 2025
Member
Author
There was a problem hiding this comment.
Regarding:
- Adjust lights (especially in asset view) so that PBR materials are as visible as blinn phong
- Make PBR the new default?
I think these should be addressed in another PR. We should implement a system so that the asset view can select a "preview scene" (which would be setup with all the lights and post-processing the user want). By default Overload would ship with a default "preview scene", but through the settings, the user should be able to change the "preview scene" to use when previewing an asset.
Once we have proper support for PBR material preview, PBR should be made the new default.
adriengivry
changed the title
litelawliet
reviewed
Feb 7, 2025
Sources/Overload/OvCore/src/OvCore/ECS/Components/CPostProcessStack.cpp
Outdated
Show resolved
Hide resolved
litelawliet
reviewed
Feb 7, 2025
…Pass.cpp Co-authored-by: Thibaut PONCHON <[email protected]>
…Stack.cpp Co-authored-by: Thibaut PONCHON <[email protected]>
litelawliet
approved these changes
Feb 7, 2025
…ssRenderPass.cpp" This reverts commit bd186b3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PostProcessStackto manage effect settings and a new component (CPostProcessStack) to expose themBlitmethod to the base rendererRGBA32F)To-Do
Screenshots