[Build] Bump minimum required Qt version to 5.5.1#1351
Merged
furszy merged 3 commits intoPIVX-Project:masterfrom Feb 24, 2020
Merged
[Build] Bump minimum required Qt version to 5.5.1#1351furszy merged 3 commits intoPIVX-Project:masterfrom
furszy merged 3 commits intoPIVX-Project:masterfrom
Conversation
1 task
furszy
approved these changes
Feb 24, 2020
furszy
added a commit
that referenced
this pull request
Mar 3, 2020
9450439 build: remove extra tokens warning (Fuzzbawls) ebb4da9 build: fix m4 escaping (Fuzzbawls) 2b3b9c3 doc: proper capitalize terms (Fuzzbawls) efee3fc build: remove duplicated QT_STATICPLUGIN define (Fuzzbawls) Pull request description: Further cleanups to the Qt m4 file that I wanted to keep separate from #1351 ACKs for top commit: random-zebra: ACK 9450439 furszy: ACK 9450439 Tree-SHA512: 1d8c0194eb72116ea4ee414c31cec8a6f472c3493a0aa63e456188aff3a2c20b8871fba22b27947ebd303b0ebe42b86a2cbaed42d3ee424a69088d8e61070b34
random-zebra
added a commit
that referenced
this pull request
Mar 23, 2020
c54fd9d [Qt] Switch to newer connect syntax (Fuzzbawls) Pull request description: Switch all Qt connections to the newer functor-based syntax. Marked [WIP] for now until larger PRs can be merged. Mostly ported from bitcoin#13529 Requires the following PR to be merged first in order to adhere to standards: - [x] #1351 ACKs for top commit: furszy: ACK c54fd9d random-zebra: ACK c54fd9d and merging... Tree-SHA512: d5222264566a8920ab97e8c586f134156d9d0514d014b430bdd47a34b0620ab94a1c6d341b6a57322f1131a8fad91a5e1af907f3bd7112d0ab5e04c4cc9f5ae5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1292, this effectively bumps the minimum required Qt version to 5.5.1.
pivx-qttargetCloses #1292