[Wallet] Remove reserve balance#1373
Merged
random-zebra merged 4 commits intoPIVX-Project:masterfrom Mar 11, 2020
Merged
Conversation
random-zebra
added
the
Needs Release Notes
Collaborator
|
Concept ACK, it is easy enough to simply lock n UTXO's if someone really doesn't want to spend/stake some coins. |
random-zebra
force-pushed
the
2020_remove_nReserveBalance
branch
from
8cdb772 to
721b109
Compare
Author
|
#1366 closed and release notes updated. |
random-zebra
removed
the
Needs Release Notes
furszy
approved these changes
Mar 11, 2020
Fuzzbawls
approved these changes
Mar 11, 2020
furszy
added a commit
that referenced
this pull request
Mar 13, 2020
…be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of #1375 Conflicts with #1373 (this to be rebased after both #1373 and #1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reservebalanceis a leftover from peercoin code which was probably never used.Currently it is also broken: the final loop in
CWallet::StakeableCoinsis useless (updating an un-used local variablenAmountSelectedand not removing any utxo from the vector of stakeable coins).Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it.
This also makes the call to
GetStakingBalancefromStakeableCoinsnot needed (thus one less loop over mapWallet txes).If this is accepted (at least conceptually) will update the release notes, and close #1366 (superseded by this one).