[RPC] Table registration update and wallet table decoupled.#1702
Merged
random-zebra merged 4 commits intoPIVX-Project:masterfrom Jul 1, 2020
Merged
[RPC] Table registration update and wallet table decoupled.#1702random-zebra merged 4 commits intoPIVX-Project:masterfrom
random-zebra merged 4 commits intoPIVX-Project:masterfrom
Conversation
furszy
changed the title
furszy
force-pushed
the
2020_rpc_wallet_table
branch
4 times, most recently
from
42980fe to
ff91002
Compare
Fuzzbawls
changed the title
|
Needs rebase. |
furszy
force-pushed
the
2020_rpc_wallet_table
branch
from
ff91002 to
9f4868a
Compare
Author
|
Rebased |
Fuzzbawls
approved these changes
Jul 1, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 9f4868a
Note: Zerocoin wallet-related RPC commands are still registered in the commands table even with -disablewallet. This, however is a minor issue as there isn't much demand to run the daemon without wallet functionality.
random-zebra
approved these changes
Jul 1, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
All good. ACK 9f4868a and merging...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work over the RPC dispatch table registration update.
Includes the following changes:
EnsureWalletIsAvailableon every RPC call --> mainly because the wallet RPC commands will only be registered if the wallet is available).to do: Move the remaining commands that were not moved from server to rpcwallet.
Next step would be bitcoin#7766 (If anyone want to tackle it, feel more than welcome to tackle it).