[Backport] Disable the mempool P2P command when bloom filters disabled#2194
Merged
furszy merged 2 commits intoPIVX-Project:masterfrom Feb 13, 2021
Merged
[Backport] Disable the mempool P2P command when bloom filters disabled#2194furszy merged 2 commits intoPIVX-Project:masterfrom
furszy merged 2 commits intoPIVX-Project:masterfrom
Conversation
Only useful to SPV peers, and attackers... like bloom is a DoS vector as far more data is sent than received.
Plus add mempool_persist.py running time and order it properly in the test list.
Fuzzbawls
approved these changes
Feb 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another DoS vector patch coming straight from bitcoin#8078.
Plus, enabled and connected the
p2p_mempool.pyfunctional test and reordered themempool_persist.pyin the list based on its time, favoring running tests in parallel.