[Docs] [Qt] RPC-Console nested commands documentation#2372
Merged
random-zebra merged 2 commits intoPIVX-Project:masterfrom May 11, 2021
Merged
[Docs] [Qt] RPC-Console nested commands documentation#2372random-zebra merged 2 commits intoPIVX-Project:masterfrom
random-zebra merged 2 commits intoPIVX-Project:masterfrom
Conversation
- Added `help-console` to the list of autocompletion strings
- Implemented requested changes to help message:
- Added an example that uses access-by-index
`getblock(getblockhash(0) true)[tx][0]`
- Replace "bracketed syntax" to "parenthesized syntax" where
applicable
- Replace "separate" with "delimit"
- Removed `<br>` and `<b>help/help-console</b>` from translation
strings, since these parts don't change between languages
- Changed examples to be based off `getblock 0` so they will work
even with pruned/no blockchain and `disablewallet` if copied and pasted
- Clarified syntax for queries of named/unnamed result objects.
furszy
approved these changes
May 10, 2021
Fuzzbawls
approved these changes
May 11, 2021
furszy
added a commit
that referenced
this pull request
Aug 19, 2021
47607df [Qt] Console: don't allow empty arguments when using the comma-syntax (random-zebra) af215ef [Qt] Console: allow empty arguments (random-zebra) Pull request description: #2372 broke the support for empty arguments `""` (which is required as first argument of `sendmany`). Backport the fix from bitcoin#9329 Thanks to @NoobieDev12 for reporting this bug. ACKs for top commit: furszy: Nice catch👌, ACK 47607df Fuzzbawls: ACK 47607df Tree-SHA512: 9ebcce3fbcb10856fc0a586365a9f0c4a3bbed5df571f21b37a143a882ab937b0fdf0502d1ba39e015cc0f745b07ed78fa8eb547110d0e53401f0d88af89cba1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2282
First commit backports bitcoin#11698, adding:
help-consolewhich is hooked after parsing the request, but before executing the RPC threadSecond commit updates the release notes.