[Policy] Child-pays-for-parent Implementation + CoinAge priority removal by random-zebra · Pull Request #2378 · PIVX-Project/PIVX

random-zebra · 2021-05-10T21:00:14Z

This PR implements CPFP transaction selection mechanism, which is the simplest "fee bumping technique" (we might want to consider implementing RBF too later on).
The algorithm in CreateNewBlock now selects transactions based on their feerate, inclusive of unconfirmed ancestor transactions. This means that a low-fee transaction can become more likely to be selected if a high-fee transaction that spends its outputs is relayed: the fee burned in the "child" transaction, actually pays for the parent tx too (hence the name).

This PR also removes completely the (already deprecated) notion of coinage-based priority and "free transactions area".

Changes backported / adapted from:

Mining: Select transactions using feerate-with-ancestors bitcoin/bitcoin#7600 [Suhas Daftuar]
[wallet] Set fLimitFree = true bitcoin/bitcoin#8287 [MarcoFalke]
Mining-related fixups for 0.13.0 bitcoin/bitcoin#8295 [Suhas Daftuar]
Improve fee estimation bitcoin/bitcoin#9138 [Alex Morcos]
Remove coin age priority and free transactions - implementation bitcoin/bitcoin#9602 [Alex Morcos]
Make boost::multi_index comparators const bitcoin/bitcoin#11847 [Suhas Daftuar]

furszy

Looking really nice, light ACK 1580748eda1e649128fdc51c0e4d2025df013ec9 .
Will get deeper.

random-zebra · 2021-06-02T09:43:23Z

Rebased, fixing conflicts.

random-zebra · 2021-06-09T13:38:34Z

Rebased.

random-zebra · 2021-06-18T11:35:32Z

Rebased

furszy

re-code ACK ce30647

furszy · 2021-06-28T14:39:29Z

Rebase needed.

random-zebra · 2021-06-28T16:48:49Z

Rebased again.

furszy · 2021-07-05T16:07:44Z

will need another rebase.

random-zebra · 2021-07-06T15:16:07Z

Rebased on master, fixing conflicts, and added last commit for #2469

furszy · 2021-07-07T20:19:16Z

Got broken after the rebase, will need to do some changes due the serialization framework changes.

This was an oversight, where blocks and mempool tracking were ignored during IBD, but transactions that arrived during IBD but were included in blocks after IBD were not ignored.

>>> backports bitcoin/bitcoin@84f7ab0 Fee estimation can just check its own mapMemPoolTxs to determine the same information. Note that now fee estimation for block processing must happen before those transactions are removed, but this shoudl be a speedup.

All decisions about whether the transactions are valid data points are made at the time the transaction arrives. Updating on blocks all the time will now cause stale fee estimates to decay quickly when we restart a node.

Make a more conservative notion of whether the node is caught up to the rest of the network and only count transactions as fee estimation data points if the node is caught up.

"startingpriority" and "currentpriority" are no longer returned in the JSON information about a mempool entry. This affects getmempoolancestors, getmempooldescendants, getmempooolentry, and getrawmempool.

>>> backports bitcoin/bitcoin@f9b9371 This a breaking API change to the prioritisetransaction RPC call which previously required exactly three arguments and now requires exactly two (hash and feeDelta). The function prioritiseTransaction is also updated.

>>> backports bitcoin/bitcoin@359e8a0 Remove GetPriority and ComputePriority. Remove internal machinery for tracking priority in CTxMemPoolEntry.

This fixes compatibility with boost 1.66

Setting minrelaytxfee to 0 will allow all transactions regardless of fee to enter your mempool until it reaches its size limit. However now that mempool limiting is governed by a separate incrementalrelay fee, it is an unnecessary restriction to prevent a minrelaytxfee of 0.

random-zebra · 2021-07-09T13:25:58Z

Fixed

Fuzzbawls

utACK f5b2e54

furszy

re-ACK f5b2e54 after rebase and last commit.

left two comments that can be tackled in a follow up PR, merging..

furszy · 2021-07-14T15:29:14Z

src/blockassembler.cpp

+            if (iter->IsShielded()) {
+                // Don't add SHIELD transactions if in maintenance (SPORK_20)
+                if (sporkManager.IsSporkActive(SPORK_20_SAPLING_MAINTENANCE)) {
+                    break;


Now that we are here, we missed to do the same with P2CS transactions. Shouldn't be added into a block if spork 19 is enabled.

furszy · 2021-07-14T15:55:36Z

src/validation.h

 /** If the tip is older than this (in seconds), the node is considered to be in initial block download. */
 static const int64_t DEFAULT_MAX_TIP_AGE = 24 * 60 * 60;
+/** Maximum age of our tip for us to be considered current for fee estimation */
+static const int64_t MAX_FEE_ESTIMATION_TIP_AGE = 3 * 60 * 60;


Can decrease this number to our block time so we don't track a much higher number of transactions in policy estimator.

random-zebra added Upstream Wallet Mempool Block Generation Mining/Staking related issues TX fees and policy labels May 10, 2021

random-zebra added this to the 6.0.0 milestone May 10, 2021

random-zebra self-assigned this May 10, 2021

random-zebra force-pushed the 202105_nopriority branch 4 times, most recently from 178a029 to 1580748 Compare May 17, 2021 23:26

furszy reviewed May 26, 2021

View reviewed changes

random-zebra requested a review from Fuzzbawls May 27, 2021 09:27

random-zebra force-pushed the 202105_nopriority branch from 1580748 to 2ab8cef Compare June 2, 2021 09:42

random-zebra force-pushed the 202105_nopriority branch from 2ab8cef to b29f42c Compare June 9, 2021 13:37

random-zebra force-pushed the 202105_nopriority branch 2 times, most recently from c41044c to ce30647 Compare June 18, 2021 11:35

furszy reviewed Jun 28, 2021

View reviewed changes

random-zebra force-pushed the 202105_nopriority branch from ce30647 to c9230e7 Compare June 28, 2021 16:47

furszy mentioned this pull request Jul 5, 2021

[WARN] Compiling 5.2.0.1 on Gentoo 32bit #2469

Closed

random-zebra force-pushed the 202105_nopriority branch from c9230e7 to ac68156 Compare July 6, 2021 15:10

random-zebra linked an issue Jul 6, 2021 that may be closed by this pull request

[WARN] Compiling 5.2.0.1 on Gentoo 32bit #2469

Closed

random-zebra and others added 23 commits July 8, 2021 18:05

[Trivial] Pass hash by const ref to CBlockPolicyEstimator::removeTx

33c9aa1

[QA] Fix random failure in wallet_abandonconflict.py

0221d5a

[wallet] Set fLimitFree = true

f682e75

[rpc] rawtx: Prepare fLimitFree to make it an option

9ca59ae

Don't track transactions at all during IBD.

c3758e1

This was an oversight, where blocks and mempool tracking were ignored during IBD, but transactions that arrived during IBD but were included in blocks after IBD were not ignored.

rename bool to validFeeEstimate

aa97809

Always update fee estimates on new blocks.

be5982e

All decisions about whether the transactions are valid data points are made at the time the transaction arrives. Updating on blocks all the time will now cause stale fee estimates to decay quickly when we restart a node.

Pass pointers to existing CTxMemPoolEntries to fee estimation

d23ebfd

Add IsCurrentForFeeEstimatation

59486ef

Make a more conservative notion of whether the node is caught up to the rest of the network and only count transactions as fee estimation data points if the node is caught up.

Add extra logging to processBlock in fee estimation.

57b7922

Add clarifying comments to fee estimation

9f47b0f

Fix edge case with stale fee estimates

142415e

[Refactor][RPC] entryToJSON/EntryDescriptionString out of mempoolToJSON

3b4d207

[rpc] Remove priority information from mempool RPC calls

cd1535a

"startingpriority" and "currentpriority" are no longer returned in the JSON information about a mempool entry. This affects getmempoolancestors, getmempooldescendants, getmempooolentry, and getrawmempool.

[Cleanup] Remove coin age priority completely

e267d02

>>> backports bitcoin/bitcoin@359e8a0 Remove GetPriority and ComputePriority. Remove internal machinery for tracking priority in CTxMemPoolEntry.

[Tests] Remove priority check for sapling txes

5858fb5

Make boost::multi_index comparators const

006136e

This fixes compatibility with boost 1.66

Remove -blockminsize option

6163d4b

[Doc] Add Mempool priority changes to release notes

784d8b4

Fix comparisons for integer expressions of different signedness

f5b2e54

random-zebra force-pushed the 202105_nopriority branch from ac68156 to f5b2e54 Compare July 8, 2021 17:32

Fuzzbawls approved these changes Jul 14, 2021

View reviewed changes

furszy approved these changes Jul 14, 2021

View reviewed changes

furszy merged commit b554c29 into PIVX-Project:master Jul 14, 2021

furszy mentioned this pull request Jul 14, 2021

Filling to BlockSizeMin with free transactions doesn't function properly #984

Closed

random-zebra mentioned this pull request Jul 14, 2021

[Wallet][RPC] Correct free tx selection and add user control #985

Closed

Conversation

random-zebra commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

random-zebra commented Jun 2, 2021

Uh oh!

random-zebra commented Jun 9, 2021

Uh oh!

random-zebra commented Jun 18, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

furszy commented Jun 28, 2021

Uh oh!

random-zebra commented Jun 28, 2021

Uh oh!

furszy commented Jul 5, 2021

Uh oh!

random-zebra commented Jul 6, 2021

Uh oh!

furszy commented Jul 7, 2021

Uh oh!

random-zebra commented Jul 9, 2021

Uh oh!

Fuzzbawls left a comment

Choose a reason for hiding this comment

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

furszy Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

furszy Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

random-zebra commented May 10, 2021 •

edited

Loading