[Util] Add validation interface logging#2548
Merged
furszy merged 5 commits intoPIVX-Project:masterfrom Sep 23, 2021
Merged
Conversation
random-zebra
force-pushed
the
202109_validation-intf-logging
branch
from
22dc168 to
ac461cf
Compare
This flag is for logging from within CValidationInterface (see btc#12994). A separate flag is desirable as the logging can be noisy and thus may need to be disabled without affecting other logging.
random-zebra
force-pushed
the
202109_validation-intf-logging
branch
from
ac461cf to
74ad1bf
Compare
Author
|
Rebased on master. |
furszy
previously approved these changes
Sep 13, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Nice logging, ACK 74ad1bf31f6ab69f8f8eddce600905627e1efc89
There is a dangling strMessageMagic extern definition in messagesigner.h that can be removed as well.
>>> coming from bitcoin/bitcoin@91a25d1
FormatStateMessage does not properly handle the case where CValidationState::IsValid() returns true. Use "Valid" for the state in this case.
All cases of CValidationState were condensed into one strprintf call. This is no longer suitable as more cases are added (e.g., IsValid).
>>> backports bitcoin/bitcoin@f9abf4a This could help debug issues where there may be race conditions at play, such as btc#12978.
random-zebra
force-pushed
the
202109_validation-intf-logging
branch
from
74ad1bf to
d6fe150
Compare
Author
|
removed extra |
furszy
approved these changes
Sep 14, 2021
1 task
random-zebra
added a commit
that referenced
this pull request
Sep 25, 2021
…e rpc/gui 7d5a01d [Refactor] Remove code duplication in sign/verify message rpc/gui (random-zebra) Pull request description: Simple refactoring commit to remove some code duplication. No functional changes. note: currently this PR includes - [x] #2548 for easier rebase later: as here we replace the `util/validation.h` header include (introduced in #2548) with `messagesigner.h`, where `strMessageMagic` was accessed directly. ACKs for top commit: furszy: simple enough, utACK 7d5a01d Fuzzbawls: ACK 7d5a01d Tree-SHA512: d43f85304f83e09a621b9526c77e2d3ed4fbeb6f2d69de35f062718b3796b2aa5616b82ffd5a2b2ea9d32429a354d7871d320b59e3bc8fa3f7eda2bc713fbc72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports bitcoin#16688 [jkczyz], which should help us debug some intermittent failures on GA (e.g. for
feature_reindexorwallet_basictests).Based on top of