[QA] Reject in-mempool llmqcomm transactions#2698
Merged
furszy merged 4 commits intoPIVX-Project:masterfrom Dec 30, 2021
Merged
[QA] Reject in-mempool llmqcomm transactions#2698furszy merged 4 commits intoPIVX-Project:masterfrom
furszy merged 4 commits intoPIVX-Project:masterfrom
Conversation
they are only valid inside blocks
furszy
reviewed
Dec 27, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
ACK 55b7d537b8cd6ad9b8e37d05e7d392378903684f
With a plus, added test coverage for the rejection of a null qfc after mining a valid qfc here:
furszy@16805d8
Can squash it on my commit as well.
1) Mine a qfc with an invalid height, which should end up being rejected. 2) Mine a null qfc before the mining phase, which should end up being rejected. 3) Mine two qfc in the same block, which should end up being rejected. 4) Mine block without qfc during the mining phase, which should end up being rejected. 5) Mine two blocks with a null qfc. 6) Try to relay the valid qfc to the mempool, which should end up being rejected. 7) Mine a qfc with an invalid quorum hash, which should end up being rejected. 8) Mine the final valid qfc in a block.
random-zebra
force-pushed
the
202112_LLMQs
branch
from
55b7d53 to
11a1b24
Compare
Author
|
Nice. 👌 Added. |
furszy
approved these changes
Dec 27, 2021
Fuzzbawls
approved these changes
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title (and discussion here: #2607 (comment)) do not accept quorum commitment txes in the mempool.
Add test coverage.