[Lint] Introduce lint-includes.sh script#2740
Merged
random-zebra merged 6 commits intoPIVX-Project:masterfrom Feb 9, 2022
Merged
[Lint] Introduce lint-includes.sh script#2740random-zebra merged 6 commits intoPIVX-Project:masterfrom
random-zebra merged 6 commits intoPIVX-Project:masterfrom
Conversation
random-zebra
previously approved these changes
Feb 7, 2022
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK 5df485e45027b8a7e69ca34579c099e3c9143681
Rather than including the implementation file into the test, which is bad practice.
Instead of throwing boost::lexical_cast<double>()
instead of boost::random::{mt19937,uniform_int_distribution}
linter to test for duplicate includes, including of `.cpp` files, and introductions/removals of Boost modules.
Fuzzbawls
force-pushed
the
2022_lint-includes
branch
from
5df485e to
ad5717d
Compare
furszy
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the
lint-includes.shshell script from upstream (first introduced in bitcoin#11878) to automatically check for duplicate includes and expanded in bitcoin#13301 and bitcoin#13385 to check for the inclusion of.cppfiles and the introduction of new boost includes, respectively.The check for enforcing bracket include syntax (bitcoin#13230) is also included, but currently disabled, as we have yet to systematically switch to that syntax preference.
Three other upstream PRs are backported here as they are directly related to the removal of some boost dependencies and are very straight forward:
NOTE: #2711 removes the dependency on
boost/tuple/tuple.hpp, so it makes sense to merge that first. submitting this now so the general concept/functionality can be reviewed prior to that PR being merged