[WIP] Deterministic zPIV Generation#416
Closed
presstab wants to merge 11 commits intoPIVX-Project:masterfrom
Closed
[WIP] Deterministic zPIV Generation#416presstab wants to merge 11 commits intoPIVX-Project:masterfrom
presstab wants to merge 11 commits intoPIVX-Project:masterfrom
Conversation
ghost
assigned
|
Is this seed just for zpiv or is it the whole wallet with piv aswell? |
Author
|
@borris345 This is only for zPIV. |
|
ACK |
Collaborator
|
Similar to my comment in #413; should this not introduce a wallet version bump? and has there been consideration made for pre-existing wallets? or is this primarily only applied to NEW wallet files? |
Author
|
This checks for the existence of a zPIV seed and if it DNE then it will add one. So this should be plug and play for new and old wallet files. |
presstab
force-pushed
the
deterministic_zpiv
branch
from
b80db31 to
3cb767e
Compare
Deterministic zPIV minting. Unit test added to zerocoin_implementation_tests.cpp. This deterministic generation model will likely be changed with further testing.
… 370ms time for 100 coins on MacOS
…llet's zPIV seed.
presstab
force-pushed
the
deterministic_zpiv
branch
from
3cb767e to
27aba2f
Compare
|
this branch has been tested against a number of different scenarios including backwards compatibility and in-flight scenarios. |
Fuzzbawls
added
the
Needs Release Notes
Fuzzbawls
removed
the
Needs Release Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fulfilling #349
Description: Deterministically generate zPiv using a given seed. This will allow for users to backup a seed, and have the ability to recover/import their zPiv using the seed value.
Status: For testing purposes only! Working on testnet. Deterministic 256 bit seed is generated and added to the wallet.dat on startup (if it does not have the seed already). Can manually replace the seed using RPC
setzpivseed. Code will likely have significant refactoring and clean up.Diagram:
