[MoveOnly] Remove zPIV code from main.cpp#609
Conversation
ghost
assigned
presstab
force-pushed
the
refactor_zpiv_main
branch
from
6d4a39b to
8171a4e
Compare
Fuzzbawls
changed the title
|
Concept ACK. I was already looking at moving the |
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
build warning and some minor nits.
src/zpivchain.h
Outdated
There was a problem hiding this comment.
build warning here:
./zpivchain.h:16:1: warning: class 'CMintMeta' was previously declared as a struct [-Wmismatched-tags]
class CMintMeta;
^
./primitives/zerocoin.h:16:8: note: previous use is here
struct CMintMeta
^
./zpivchain.h:16:1: note: did you mean struct here?
class CMintMeta;
^~~~~
struct
1 warning generated.
src/zpivchain.h
Outdated
There was a problem hiding this comment.
nit: list c++ standard includes after in-tree includes
src/zpivchain.h
Outdated
There was a problem hiding this comment.
nit: have an empty line between the copyright header and the #ifndef
src/zpivchain.cpp
Outdated
There was a problem hiding this comment.
nit: have an empty line between the copyright header and the first #include
presstab
force-pushed
the
refactor_zpiv_main
branch
from
8171a4e to
873ef19
Compare
|
@Fuzzbawls thanks for the quick review. Styling changes have been fixed and pushed. |
|
I've been testing this before the changes proposed by fuzzbawls and ended up getting deadlocks crashes. The issue was appearing upon unlocking the wallet on a Debian 9 x64. I was unable to reproduce the issue on Windows so far. |
|
I won't be able to test further before Monday. I don't know how the issue could be related but it appeared with this pr. |
Warrows
left a comment
Warrows
left a comment
There was a problem hiding this comment.
Seems like the deadlock is unrelated to this PR. Sorry for the delay, that's a ACK from me.
873ef19 Remove zPIV code from main.cpp (presstab) Tree-SHA512: 480c3dc43c25de7223468842e15f6b2f4ac4cfcef5e920d4b69dcd489cc924fe89ad262f37233c040246e291de791abdc733beb5e6e7dda6bc511b7399a0178a
Github-Pull: PIVX-Project#609 Rebased-From: 873ef19
4 participants
No description provided.