[Main] Check whether tx is in chain in ContextualCheckZerocoinMint().#610
Merged
presstab merged 1 commit intoPIVX-Project:masterfrom May 14, 2018
Merged
Conversation
ghost
assigned
Collaborator
|
ACK c4141aa Small note however: wallets that already have a block marked as invalid will need to use |
Fuzzbawls
changed the title
presstab
added a commit
that referenced
this pull request
May 14, 2018
…ocoinMint(). c4141aa Check whether tx is in chain in ContextualCheckZerocoinMint(). (presstab) Tree-SHA512: 6536bb9b49ae8548b8ce4840df87a0d1384b50bfca669eedffd541838345c476e166a62aa89d4022e306822bb2063bc9e509347fdd366aaa1a9a62e434b84e35
Warrows
reviewed
Jun 20, 2018
| //See if this coin has already been added to the blockchain | ||
| uint256 txid; | ||
| if(zerocoinDB->ReadCoinMint(coin.getValue(), txid)) | ||
| int nHeight; |
There was a problem hiding this comment.
Shouldn't nHeight be given a value here?
Closed
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 6, 2018
Github-Pull: PIVX-Project#610 Rebased-From: c4141aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues that certain wallets have had with reorgs where the new blocks are rejected because the mint in the zerocoindb was not properly purged.