[Main] Write to the zerocoinDB in batches#636
Merged
Mrs-X merged 1 commit intoPIVX-Project:masterfrom Jun 28, 2018
Merged
Conversation
instead of using a separate write operation for each and every bit of data that needs to be flushed to disk, utilize leveldb's batch writing capability.
ghost
assigned
Collaborator
Author
|
thinking about this further...I could probably add a guard in |
Fuzzbawls
added
the
Needs Release Notes
|
Are you going to add this guard, or is the PR ready for test and review? |
Collaborator
Author
|
@Warrows can be tested as-is. The internal batch write functions already don't do anything except a |
Mrs-X
approved these changes
Jun 28, 2018
Mrs-X
left a comment
Mrs-X
left a comment
There was a problem hiding this comment.
ACK (and yes, it's indeed faster ;-) ) and merging...
Mrs-X
added a commit
that referenced
this pull request
Jun 28, 2018
cd672cd [Main] Write to the zerocoinDB in batches (Fuzzbawls) Tree-SHA512: 031d41bf5d09b2f3636e191e0de5fbf8062cd967f76a25fe2705dceaf4e9a65875c394af5fb6e2ad08739a4acd3fa7945eff4594a11040e5aa9cf2b93ca04cd8
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jul 6, 2018
instead of using a separate write operation for each and every bit of data that needs to be flushed to disk, utilize leveldb's batch writing capability. Github-Pull: PIVX-Project#636 Rebased-From: cd672cd
Fuzzbawls
removed
Needs Release Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of using a separate write operation for each and every bit of
data that needs to be flushed to disk, utilize leveldb's batch writing
capability.
The primary area of improvement this offers is when reindexing the zerocoinDB (
-reindexzerocoin), which went from needing multiple hours on my system to mere minutes.Secondary improvement area is in
ConnectBlock()when multiple zerocoin transactions are involved.