[Consensus] Define SPORK_17#975
Merged
furszy merged 2 commits intoPIVX-Project:masterfrom Oct 24, 2019
Merged
Conversation
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
8 times, most recently
from
bf1a2ac to
6ea8599
Compare
Author
|
rebased |
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
from
6ea8599 to
d668235
Compare
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
from
d668235 to
bc4a99f
Compare
Author
|
Rebased. |
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
from
bc4a99f to
0ff825d
Compare
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
2 times, most recently
from
bc90cdd to
6240435
Compare
Author
|
Rebased on top of #1000 |
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
from
6240435 to
5a6eab5
Compare
Author
|
Rebased. |
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
6 times, most recently
from
4042c88 to
f69e7af
Compare
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
10 times, most recently
from
8e7a032 to
8ec8f13
Compare
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
7 times, most recently
from
41265df to
c5c56f9
Compare
|
rebase needed |
define SPORK_17_COLDSTAKING_ENFORCEMENT. When such spork is not active, transactions with P2CS outputs are rejected
random-zebra
force-pushed
the
2019_coldStaking_spork
branch
from
c5c56f9 to
fffc6c5
Compare
Author
|
Rebased |
furszy
approved these changes
Oct 23, 2019
Fuzzbawls
approved these changes
Oct 23, 2019
furszy
added a commit
that referenced
this pull request
Oct 24, 2019
fffc6c5 [Core] Lower the banscore for P2CS when spork 17 disabled to 10 (random-zebra) 20effe6 [Consensus] Set Cold Staking activation via SPORK (random-zebra) Pull request description: This is based on top of #955 (only the last commit, 5a6eab590505d409481ee3f385d65b09f40bb8fd , is relevant for this PR). It sets Cold Staking activation via SPORK instead of having it height-based. When `SPORK_17_COLDSTAKING_ENFORCEMENT` is **not** active (default), transactions with P2CS outputs are rejected on the network. This way only cold-staking and new delegations are disabled while coin-owners can still spend their coins. ACKs for top commit: furszy: ACK fffc6c5 Fuzzbawls: ACK fffc6c5 Tree-SHA512: bac8e267d0c6f74896cf6915c67de6880d033aaf757f3ac0564bf816bf5fa5abe91b41dc8f90328e8a028026ddd1e6636023c6bcc405041813841ee231e22565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on top of #955 (only the last commit, 5a6eab590505d409481ee3f385d65b09f40bb8fd , is relevant for this PR).
It sets Cold Staking activation via SPORK instead of having it height-based.
When
SPORK_17_COLDSTAKING_ENFORCEMENTis not active (default), transactions with P2CS outputs are rejected on the network. This way only cold-staking and new delegations are disabled while coin-owners can still spend their coins.