[Consensus] Define SPORK_18#995
Merged
furszy merged 4 commits intoPIVX-Project:masterfrom Oct 24, 2019
Merged
Conversation
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
3 times, most recently
from
8d04dd7 to
fe79f3d
Compare
Author
|
Rebased on top of #1000 |
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
from
fe79f3d to
c408c5b
Compare
Author
|
Rebased. |
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
2 times, most recently
from
449039f to
d5b9d90
Compare
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
4 times, most recently
from
a25472f to
913139a
Compare
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
3 times, most recently
from
fcd0600 to
4177ca6
Compare
|
rebase needed. |
Author
|
#975 will generate other conflicts. |
define SPORK_18_ZEROCOIN_PUBLICSPEND_V4. When such spork is not active, zerocoin publicspend version must be 3. Otherwise must be 4.
random-zebra
force-pushed
the
2019_rand-schnorr_spork
branch
from
4177ca6 to
e06f7b6
Compare
Author
|
Rebased |
furszy
approved these changes
Oct 24, 2019
Warrows
approved these changes
Oct 24, 2019
furszy
added a commit
that referenced
this pull request
Oct 24, 2019
e06f7b6 [Tests] Minor optimizations in zerocoin_valid_public_spend test (random-zebra) cdc18ea [RPC] fix parameters check for spendzerocoin (missing ispublicspend) (random-zebra) 72bc39a [Tests] Add zerocoin_valid_public_spend to testRunner (random-zebra) 26045d3 [Consensus] Set zc PublicSpend version v3/v4 via SPORK (random-zebra) Pull request description: This follows #936 It sets the required version for zerocoin PublicSpends via SPORK instead of having it height-based. When `SPORK_18_ZEROCOIN_PUBLICSPEND_V4` is not active (default), the required version is v3 (where old version 1 serials cannot be spent. ref: #891 ). It also fixes the relative functional test `zerocoin_valid_public_spend.py` and adds it to the test_runner. ACKs for top commit: furszy: utACK e06f7b6 Warrows: utACK e06f7b6 Tree-SHA512: 07f18e77a91503f5d48dafad32364cc6292ffd1f9a3f9286a78de72dafc98b07342e6abd96eaabe55d20193f10be383c8d5bbac1b33c45712ade8c522e457b3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #936
It sets the required version for zerocoin PublicSpends via SPORK instead of having it height-based.
When
SPORK_18_ZEROCOIN_PUBLICSPEND_V4is not active (default), the required version is v3 (where old version 1 serials cannot be spent. ref: #891 ).It also fixes the relative functional test
zerocoin_valid_public_spend.pyand adds it to the test_runner.