feat: randomly generate names for in-game account creation#69
Merged
jacobtread merged 1 commit intomasterfrom May 12, 2024
Merged
feat: randomly generate names for in-game account creation#69jacobtread merged 1 commit intomasterfrom
jacobtread merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new updated games API that allows exposing the active games list the additional option for hiding the players list was added because the names in the player list may contain email addresses of users who signed up in the in-game account creator this is because the in-game account creator does not allow the user to provide a username.
After account creation users could already change their name using the dashboard however that may not be something someone will do if they wanted to just quickly play the game. (Accounts created through the dashboard or through Origin have usernames associated with them so there's no need for these to change)
This change uses a random collection of adjectives and nouns along with a randomly generated sequence of numbers to generate a random username for these accounts rather than relying on the email to pick the name.
Below is an example of a randomly generated name ("lowly-tendency-3799"):
