Merged
Conversation
ljeub-pometry
force-pushed
the
feature/IsValidFilter
branch
from
7f2d03d to
dfbb7a8
Compare
…eView to make some implementations possible
ljeub-pometry
force-pushed
the
feature/IsValidFilter
branch
from
14b8b49 to
bab1997
Compare
![github-actions[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 156f747 | Previous: 48a104d | Ratio |
|---|---|---|---|
lotr_graph_window_10/iterate edges |
59020 ns/iter (± 131) |
28682 ns/iter (± 97) |
2.06 |
lotr_graph_window_50_layered/iterate edges |
104087 ns/iter (± 556) |
49863 ns/iter (± 251) |
2.09 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
259529 ns/iter (± 2394) |
121480 ns/iter (± 1820) |
2.14 |
lotr_graph_persistent_window_50_layered/has_node_existing |
121 ns/iter (± 75) |
26 ns/iter (± 1) |
4.65 |
lotr_graph_persistent_window_50_layered/iterate nodes |
28892 ns/iter (± 53) |
8586 ns/iter (± 60) |
3.37 |
This comment was automatically generated by workflow using github-action-benchmark.
|
|
fabianmurariu
approved these changes
Jun 5, 2025
| #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Default, Serialize, Deserialize)] | ||
| pub struct ELID { | ||
| pub edge: EID, | ||
| layer_and_deletion: usize, |
Collaborator
There was a problem hiding this comment.
or maybe use this?
https://crates.io/crates/bitfield-struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add_node.add_node.latest_timesemantics for the PersistentGraph to return the time of the last update for the node/edge/graph in the current view or the start of the window if there are no updates.earliest_timeandlatest_timewithin a filtered Event Graph will now reflect the updates within the graph view instead of just window bounds.Why are the changes needed?
Fixes #1050, fixes #1787, fixes #1191
Fixes #1779
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?