Conversation
![github-actions[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 1fdd950 | Previous: 12be753 | Ratio |
|---|---|---|---|
lotr_graph_subgraph_10pc/num_nodes |
14 ns/iter (± 0) |
4 ns/iter (± 0) |
3.50 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'GraphQL Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 1fdd950 | Previous: 12be753 | Ratio |
|---|---|---|---|
addNode |
36 req/s |
1480 req/s |
41.11 |
This comment was automatically generated by workflow using github-action-benchmark.
ljeub-pometry
requested changes
Feb 3, 2026
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
Some minor things but looking good overall
python/tests/test_base_install/test_filters/test_edge_filter.py
Outdated
Show resolved
Hide resolved
python/tests/test_base_install/test_graphql/test_filters/test_edge_filter_gql.py
Outdated
Show resolved
Hide resolved
python/tests/test_base_install/test_graphql/test_filters/test_node_filter_gql.py
Show resolved
Hide resolved
ljeub-pometry
requested changes
Feb 4, 2026
python/tests/test_base_install/test_filters/test_edge_filter.py
Outdated
Show resolved
Hide resolved
python/tests/test_base_install/test_filters/test_edge_filter.py
Outdated
Show resolved
Hide resolved
python/tests/test_base_install/test_filters/test_edge_filter.py
Outdated
Show resolved
Hide resolved
raphtory/src/db/graph/views/filter/model/is_active_node_filter.rs
Outdated
Show resolved
Hide resolved
ljeub-pometry
approved these changes
Feb 4, 2026
ljeub-pometry
added a commit
that referenced
this pull request
Feb 6, 2026
* impl bool filters, add tests (#2467) * impl bool filters, add tests * fix imports * add review suggestions * add more tests * add gql tests * more tests * fix test * add more review suggestions * add more review suggestions * add delete_edge for py graph, add tests, add review suggestions * fix tests * chore: apply tidy-public auto-fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fixes for docker ci (#2470) * merge clis and configs (#2457) * merge clis and configs * commit missing main file * fix compilation errors and python imports * cli actually working * add server subcommand * add help messages and version option * fix compilation errors * add AppConfigBuilder import back * simplify the deadlock tests * revert ui-test commit * switch to parking_lot for deadlock tests * clear up the main.rs in raphtory-graphql * chore: apply tidy-public auto-fixes --------- Co-authored-by: Fabian Murariu <[email protected]> Co-authored-by: Fabian Murariu <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: apply tidy-public auto-fixes --------- Co-authored-by: Shivam <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pedro Rico Pinazo <[email protected]> Co-authored-by: Fabian Murariu <[email protected]> Co-authored-by: Fabian Murariu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2466