Autofix SA1518: No extra blank lines at the end of the file by xtqqczze · Pull Request #13574 · PowerShell/PowerShell

xtqqczze · 2020-09-04T13:39:36Z

PR Summary

Autofix SA1518: The code must not contain blank lines at the end of the file.

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1518.md

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

This change is

…he file

ghost · 2020-09-12T02:00:14Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw · 2020-09-15T21:14:39Z

@PowerShell/powershell-maintainers reviewed this PR and agreed to reject it. We have been telling contributors to add a new line at the end for quite some time, because GitHub code difference usually complains about not having a new line at the end.

xtqqczze · 2020-09-16T01:36:36Z

@daxian-dbw According to the documentation for SA1518, the default setting for this rule is: "Files are allowed to end with a single newline character, but it is not required".

To be clear, while this PR removes the necessary blank lines at the the of files, it does not remove the single newline charactor at the end of the last line (which may in fact cause issues with diff tools).

iSazonov · 2020-09-16T05:01:53Z

@daxian-dbw The PR removes extra second empty line at EOF.

src/Microsoft.PowerShell.Commands.Management/commands/management/AddContentCommand.cs

xtqqczze · 2020-10-13T00:12:28Z

@iSazonov Please reopen.

ghost · 2020-10-20T14:00:09Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze · 2020-10-21T13:34:24Z

@daxian-dbw The PR remove extra second empty line at EOF.

@daxian-dbw Can you please re-review, I would like this merged early for 7.2.0-preview.1.

ghost · 2020-10-28T14:00:05Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

TravisEz13

Reviewed 57 files

TravisEz13 · 2020-10-28T21:35:31Z

@PoshChan Please remind me in 7 days

ghost · 2020-11-05T02:00:09Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-11-05T04:40:37Z

@TravisEz13 Please continue your review.

ghost · 2020-11-17T23:01:42Z

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Autofix SA1518: The code must not contain blank lines at the end of t…

67015b8

…he file

xtqqczze requested review from adityapatwardhan, anmenaga and daxian-dbw as code owners September 4, 2020 13:39

ghost assigned iSazonov Sep 4, 2020

iSazonov approved these changes Sep 4, 2020

View reviewed changes

iSazonov added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log size/XL Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers labels Sep 4, 2020

ghost added the Review - Needed The PR is being reviewed label Sep 12, 2020

daxian-dbw closed this Sep 15, 2020

ghost removed the Review - Needed The PR is being reviewed label Sep 15, 2020

daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 15, 2020

Steg17 reviewed Sep 16, 2020

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/AddContentCommand.cs Show resolved Hide resolved

iSazonov reopened this Oct 13, 2020

iSazonov added this to the 7.2.0-preview.1 milestone Oct 13, 2020

ghost added the Review - Needed The PR is being reviewed label Oct 20, 2020

ghost removed the Review - Needed The PR is being reviewed label Oct 21, 2020

ghost added the Review - Needed The PR is being reviewed label Oct 28, 2020

TravisEz13 reviewed Oct 28, 2020

View reviewed changes

ghost removed the Review - Needed The PR is being reviewed label Oct 28, 2020

ghost added the Review - Needed The PR is being reviewed label Nov 5, 2020

ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020

iSazonov approved these changes Nov 11, 2020

View reviewed changes

iSazonov merged commit 4d2965a into PowerShell:master Nov 11, 2020

iSazonov changed the title ~~Autofix SA1518: No blank lines at the end of the file~~ Autofix SA1518: No extra blank lines at the end of the file Nov 11, 2020

xtqqczze deleted the SA1518 branch November 11, 2020 17:39

xtqqczze mentioned this pull request Nov 11, 2020

Add StyleCop.Analyzers package #13963

Merged

xtqqczze mentioned this pull request Sep 3, 2025

Ensure .cs files end with exactly one newline #25968

Merged

Conversation

xtqqczze commented Sep 4, 2020 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

ghost commented Sep 12, 2020

Uh oh!

daxian-dbw commented Sep 15, 2020

Uh oh!

xtqqczze commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

xtqqczze commented Oct 13, 2020

Uh oh!

ghost commented Oct 20, 2020

Uh oh!

xtqqczze commented Oct 21, 2020

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Oct 28, 2020

Uh oh!

ghost commented Nov 5, 2020

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

ghost commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xtqqczze commented Sep 4, 2020 •

edited by iSazonov

Loading

xtqqczze commented Sep 16, 2020 •

edited

Loading

iSazonov commented Sep 16, 2020 •

edited

Loading