Replace UTF8Encoding(false) with Encoding.Default part 2#18356
Replace UTF8Encoding(false) with Encoding.Default part 2#18356daxian-dbw merged 2 commits intoPowerShell:masterfrom
UTF8Encoding(false) with Encoding.Default part 2#18356Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
left a comment
There was a problem hiding this comment.
Do we not have concerns that the .Net default will be changed in the future while we don't want such a change?
| if (s_defaultEncoding == null) | ||
| { | ||
| // load all available encodings | ||
| EncodingRegisterProvider(); |
There was a problem hiding this comment.
I don't remember if we have tests for that.
Since .NET Core 2.0, In the unlikely event of a breaking change to cc: @JamesWTruher |
|
@iSazonov You may be interested in the .NET breaking change to proposal to |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Follow-up: #18144.
cc: @iSazonov, @daxian-dbw, @JamesWTruher
Context: dotnet/runtime#45541, #5080