Fix Start-Process -Wait with -Credential#19096
Conversation
fb6d94b to
05e9a68
Compare
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
05e9a68 to
05989a8
Compare
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
05989a8 to
1b48881
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Show resolved
Hide resolved
Allows a non-administrator user to be able to -Wait on a Start-Process call with a custom credential specified.
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Thanks for submitting this! LGTM. The changes here helped me understand what exactly you were asking for previously.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@SteveL-MSFT is this waiting on anything? |
|
@jborean93 Thanks for your contribution! |
|
🎉 Handy links: |
PR Summary
Allows a non-administrator user to be able to -Wait on a Start-Process call with a custom credential specified.
Currently thinking off a way I can test out this scenario.After creating a test to run in CI I've found that it's too hard to create a reliable test that wouldn't block the whole runner on a failing scenario. The test itself also required admin access and was quite complicated to set up all the synchronisation work so I've decided not to include it.Fixes: #17033
Alternative to #19082
PR Context
#17033
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).