docs: fix typos#19175
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
I don't really understand the error messages with the CI, could someone help me out by telling me what's going wrong? Thanks 😁 |
|
@microsoft-github-policy-service agree |
|
@Lioness100 The PR is too large. Please split the PR and group changes in some way (by file types, by folders). |
|
Hi @iSazonov! There are a lot of folders in this PR, and I don't want to inconvenience reviewers with a barrage of PRs. Would you allow this PR to go through if I removed any code changes and only kept typo fixes in comments? If not, could you provide a bit more specific guidance into how to split the PRs? Thanks <3333 |
|
@Lioness100 I mean folders in |
| { | ||
| StringBuilder filter = new StringBuilder(); | ||
| foreach (DictionaryEntry entry in seletorset) | ||
| foreach (DictionaryEntry entry insselectorset) |
There was a problem hiding this comment.
This doesn't look right
It would be a lot easier to review if you split this into two PRs. One for comments and one for code. The comments should be easier to review.
| /> | ||
| <task | ||
| message="$(string.PS_PROVIDER.task.T_M3P-ConfiguarationTask.message)" | ||
| message="$(string.PS_PROVIDER.task.T_M3P-ConfigurationTask.message)" |
There was a problem hiding this comment.
This is actually in the PowerShell-Native repo
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Hi, sorry for the delay, I've been busy. Would you rather Para separated by folders as @iSazonov suggested, or by code vs comments, as @TravisEz13 suggested? |
|
@Lioness100 No doubt it is better to separate code and comments. If there will still be a lot of changes, please pack the changes into small commits / PRs. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
PR Summary
This PR fixes some typos throughout the repository. I'm unfamiliar with this codebase, so if I broke anything that needs to be reverted, or if you want me to split this into multiple prs, or anything else please let me know! There were many many "suspected" typos to filter through (52k, although most were duplicates), so I'm sure I've missed or incorrectly handled a few. I have not yet built and tested my changes because I have to leave to do something right now, but I will get to it ASAP.
PR Context
This was a trial run for a CLI I made). I was looking for a very big repository that probably had some typos, and this was a great fit :) thanks alot.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).