WebRequestPSCmdlet.Common.cs remove { } and indentation#19229
WebRequestPSCmdlet.Common.cs remove { } and indentation#19229daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM. It's easier to review by ignoring the white-space changes:
https://github.com/PowerShell/PowerShell/pull/19229/files?w=1
|
🎉 Handy links: |
All retries are done with recursive GetResponse added by PowerShell#19229. The do loop was a leftover from the old way of doing things, it never actually gets triggered, and redirects previously had internal GetResponse that bypassed it, but when I unified the logic to unify the verbose messages, it now follows the flow "properly" and got stuck in the do/while instead of return the response, causing it to reuse the request and trigger an exception.
PR Summary
Small cleanup, remove { } and indentation because #19173 removes the using in the preceding line
PR Context
Cleanup before #19173 discussed with @stevenebutler
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).