Fix Out-GridView by implementing Clone() method to replace old use of binary format serialization#20050
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Aug 1, 2023
Merged
Conversation
…of binary format serialization
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Collaborator
JamesWTruher
left a comment
There was a problem hiding this comment.
do we have validation anywhere for this?
Member
Author
|
@JamesWTruher no automation, so just some manual validation with filtering |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The PR to move to .NET 8 preview.4 removed all use of the binary format serializer since it is no longer supported in .NET. This inadvertently broke
Out-GridViewwhich heavily depends on binary serialization to make copies of FilterRules. The fix here is to introduce a newClone()method in the abstract base class and implement it for each of the derived FilterRules.PR Context
Fix #20015
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).