[release/v7.4] Fix path to metadata.json in channel selection script#26399
Merged
TravisEz13 merged 1 commit intoPowerShell:release/v7.4from Nov 10, 2025
Merged
Conversation
TravisEz13
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Windows Store publishing pipeline to adjust configuration handling, remove redundant tasks, and fix variable references for the MSIX bundle creation and publishing process.
Key Changes:
- Commented out the MSIX bundle signing task
- Removed the separate StoreBroker package creation task for Stable/LTS channels
- Updated PDP file modification to use XML namespaces and set attributes instead of inner text
- Fixed variable reference in channelSelection.yml from undefined
$repoRootto explicit Build.SourcesDirectory path
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .pipelines/templates/package-create-msix.yml | Commented out signing task, added AppId configuration fields, updated XML namespace handling for PDP files, removed duplicate StoreBroker package task and associated variable assignments, changed service endpoint to Private, added store failure log upload |
| .pipelines/templates/channelSelection.yml | Fixed metadata.json path from undefined $repoRoot variable to explicit $(Build.SourcesDirectory)/PowerShell/tools/metadata.json |
| .pipelines/store/SBConfig.json | Added "PDP.xml" to PDPInclude array and changed targetPublishMode from "NotSet" to "Immediate" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TravisEz13
commented
Nov 6, 2025
TravisEz13
commented
Nov 6, 2025
TravisEz13
force-pushed
the
backport/release/v7.4/pr/26180
branch
from
65dd88b to
02630d3
Compare
jshigetomi
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26180 to release/v7.4
Triggered by @TravisEz13
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
This backport fixes the path to
metadata.jsonin the channel selection script (.pipelines/templates/channelSelection.yml). The original path$repoRoot/tools/metadata.jsonwas incorrect in the Azure DevOps pipeline context and has been updated to$(Build.SourcesDirectory)/PowerShell/tools/metadata.json.This change was part of PR #26180 (merge of v7.6.0-preview.5 release branch back to master), specifically from commit 873db35. The fix is critical for the release pipeline's channel selection logic to function correctly.
Regression
This is a fix for infrastructure, not a regression.
Testing
The fix has been validated in the v7.6.0-preview.5 release branch and merged back to master via PR #26180. It corrects the pipeline variable reference to properly locate the metadata.json file during builds.
Risk
Medium - This change modifies CI/CD infrastructure (Azure DevOps pipeline templates). While the change itself is small and straightforward (correcting a file path), it affects the release pipeline's channel selection logic. The risk is medium because:
The fix aligns the 7.4 release branch with the corrected implementation already in master, reducing divergence in pipeline infrastructure.