Update the WCF packages to the latest version that is compatible with v4.10.3#26406
Merged
daxian-dbw merged 9 commits intoPowerShell:masterfrom Nov 11, 2025
Merged
Update the WCF packages to the latest version that is compatible with v4.10.3#26406daxian-dbw merged 9 commits intoPowerShell:masterfrom
daxian-dbw merged 9 commits intoPowerShell:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes commented-out package references and updates System.ServiceModel packages to version 10.0.0-rc.2.final.
- Removes commented-out package references that were causing NU1510 warnings in System.Management.Automation.csproj
- Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final (major version upgrade)
- Removes several System.ServiceModel packages (Duplex, Security, Private.ServiceModel) and associated comments about version pinning
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/System.Management.Automation.csproj | Cleans up commented-out package references for DiagnosticSource, IO.FileSystem.AccessControl, Security.AccessControl, and Text.Encoding.CodePages |
| src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj | Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final and removes Duplex, Security, and Private.ServiceModel packages along with their explanatory comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TravisEz13
reviewed
Nov 10, 2025
TravisEz13
approved these changes
Nov 11, 2025
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 20, 2025
Merged
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #19238
PackageReferenceitems that were commented out.10.0.0-rc.2.final.The
10.0.0-rc.2.finalversionServiceModelpackages are backward compatible:The packages
System.ServiceModel.Duplex,System.ServiceModel.Security, andSystem.Private.ServiceModelare discontinued.The package
System.ServiceModel.Primitivesships 3 facade assembliesSystem.ServiceModel.dllSystem.ServiceModel.Duplex.dllSystem.ServiceModel.Security.dllThe package
System.Private.ServiceModelis no longer needed, as every package now carries its own implementation.I have verified that the
ActiveDirectorymodule can be correctly imported with in PowerShell built with the10.0.0-rc.2.finalWCF packages.Before this change, the
*ServiceModel*assemblies carried by PowerShell are:After this change, the
*ServiceModel*assemblies carried by PowerShell are:The difference of Before vs. After is shown below. The
System.Private.ServiceModel.dllis no longer needed with the latest version, and theSystem.ServiceModel.NetFramingBase.dllis a new dependency of theSystem.ServiceModel.NetTcp.dll.