[release/v7.4] Fix condition syntax for StoreBroker package tasks in MSIX pipeline#26434
Merged
TravisEz13 merged 1 commit intoPowerShell:release/v7.4from Feb 10, 2026
Conversation
TravisEz13
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports a fix for OneBranch condition syntax in the MSIX pipeline from the main branch to release/v7.4. The fix corrects the variable reference pattern in StoreBroker package task conditions to use the proper variables['VAR'] syntax instead of the incorrect '$(VAR)' string expansion syntax.
Key changes:
- Updates two condition expressions in package-create-msix.yml to use correct OneBranch variable reference syntax
- Adds comprehensive instruction documentation for OneBranch condition syntax patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .pipelines/templates/package-create-msix.yml | Corrects condition syntax from '$(PREVIEW)' to variables['PREVIEW'] and similar for STABLE/LTS conditions |
| .github/instructions/onebranch-condition-syntax.instructions.md | Adds detailed instruction file documenting correct OneBranch condition syntax patterns, examples, and troubleshooting guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
added
the
Review - Needed
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
jshigetomi
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26427 to release/v7.4
Triggered by @TravisEz13 on behalf of @TravisEz13
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
Fixes OneBranch condition syntax in MSIX pipeline that prevents StoreBroker package tasks from running correctly on release branches.
Regression
This is a tooling fix for pipeline configuration, not fixing a regression.
Testing
Verified by:
Risk
High risk as it modifies build pipeline configuration, but necessary to ensure proper package creation on release branches. Not taking this change would prevent StoreBroker packages from being created correctly. The fix follows documented OneBranch condition syntax patterns and has been validated in the main branch.