Bring over all changes for MSIX packaging template#26932
Bring over all changes for MSIX packaging template#26932jshigetomi merged 1 commit intoPowerShell:release/v7.4from
Conversation
jshigetomi
added
the
CL-BuildPackaging
There was a problem hiding this comment.
Pull request overview
Updates the MSIX packaging pipeline template to explicitly branch StoreBroker package creation based on the selected channel (LTS/Stable/Preview), enabling the correct Store publishing service connection to be used per channel.
Changes:
- Sets job-scoped
LTS,STABLE, andPREVIEWvariables derived fromChannelSelectionoutputs. - Adds a debug step to log the channel variables after configuration updates.
- Splits StoreBroker package creation into Preview vs Stable/LTS tasks with channel-gated conditions and channel-appropriate service endpoints.
| Write-Host "##vso[task.setvariable variable=ServiceConnection]$($config.ServiceEndpoint)" | ||
| Write-Host "##vso[task.setvariable variable=SBConfigPath]$($sbConfigPath)" | ||
|
|
||
| # These variables are used in the next tasks to determine which ServiceEndpoint to use | ||
| $ltsValue = $IsLTS.ToString().ToLower() | ||
| $stableValue = $IsStable.ToString().ToLower() | ||
| $previewValue = $IsPreview.ToString().ToLower() | ||
|
|
||
| Write-Verbose -Verbose "About to set variables:" | ||
| Write-Verbose -Verbose " LTS=$ltsValue" | ||
| Write-Verbose -Verbose " STABLE=$stableValue" | ||
| Write-Verbose -Verbose " PREVIEW=$previewValue" | ||
|
|
||
| Write-Host "##vso[task.setvariable variable=LTS]$ltsValue" | ||
| Write-Host "##vso[task.setvariable variable=STABLE]$stableValue" | ||
| Write-Host "##vso[task.setvariable variable=PREVIEW]$previewValue" |
There was a problem hiding this comment.
The new LTS/STABLE/PREVIEW variable plumbing makes the previously-set ServiceConnection value redundant: ServiceConnection is still set from $config.ServiceEndpoint, but it is never referenced anywhere else in this template, and $config.ServiceEndpoint itself is only used for that variable. Consider removing ServiceConnection/ServiceEndpoint from this step (or wiring tasks to use it, if that’s intended) to avoid dead code and configuration drift.
PR Summary
This pull request enhances the
.pipelines/templates/package-create-msix.ymlpipeline by introducing explicit handling for LTS, Stable, and Preview build types, allowing for more flexible and targeted package publishing. The main changes involve setting new variables to distinguish between these build types and updating the publishing tasks to use the correct service endpoints based on these variables.Pipeline variable management and publishing logic:
LTS,STABLE,PREVIEW) that indicate the type of build, making it easier to control subsequent publishing tasks.Store package publishing tasks:
PREVIEWvariable is true and uses theStoreAppPublish-Previewservice endpoint.StoreAppPublish-Stableendpoint and running only when eitherSTABLEorLTSis true.PR Context
PR fixes msix packaging template for v7.4.14
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header