[release/v7.4] Correct the package name for .deb and .rpm packages (#26877)#26954
Conversation
Co-authored-by: Copilot <[email protected]> Co-authored-by: Travis Plunk <[email protected]>
jshigetomi
added
the
CL-BuildPackaging
jshigetomi
changed the title
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.4 to correct Linux package naming so .deb/.rpm preview channel packages use the expected powershell-preview name (while keeping macOS .pkg naming consistent).
Changes:
- Update
New-UnixPackageto derive$IsPreviewfrom the version string and applypowershell-previewnaming for preview deb/rpm packages (but not forosxpkg). - Update
macos-ci.ymlto gate the macOS packaging job on thepackagingChangedpath-filter output and expose that output from thechangesjob.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tools/packaging/packaging.psm1 |
Adjusts package name selection so preview deb/rpm packages are named powershell-preview (LTS remains powershell-lts). |
.github/workflows/macos-ci.yml |
Changes macOS packaging job trigger condition to use packagingChanged from the repo’s path-filtering action. |
| needs: | ||
| - changes | ||
| if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }} | ||
| if: ${{ needs.changes.outputs.packagingChanged == 'true' }} |
There was a problem hiding this comment.
The job now runs only when needs.changes.outputs.packagingChanged == 'true', but the path-filters action currently (1) does not set packagingChanged for non-PR events (push/workflow_dispatch) and (2) does not include test/packaging/macos/ (or macos-ci.yml) in its packagingChanged paths. This means macOS packaging validation can be skipped when it should run. Consider either expanding the condition (e.g., include source/buildModuleChanged) or updating the path filter so packagingChanged is computed for these cases (ideally in default branch, then backport).
| if: ${{ needs.changes.outputs.packagingChanged == 'true' }} | |
| if: ${{ needs.changes.outputs.packagingChanged == 'true' || needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }} |
| $IsPreview = Test-IsPreview -Version $Version -IsLTS:$LTS | ||
|
|
||
| # For deb/rpm packages, use the '-lts' and '-preview' channel suffix variants to match existing names on packages.microsoft.com. | ||
| # For osxpkg package, only LTS packages get a channel suffix in the name. |
There was a problem hiding this comment.
Grammar nit in comment: “For osxpkg package” should be “For osxpkg packages” (or “For the osxpkg package type”).
| # For osxpkg package, only LTS packages get a channel suffix in the name. | |
| # For osxpkg packages, only LTS packages get a channel suffix in the name. |
…owerShell#26877) (PowerShell#26954) Co-authored-by: Dongbo Wang <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Travis Plunk <[email protected]>
Backport of #26877 to release/v7.4
Triggered by @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Risk
REQUIRED: Check exactly one box.