[release/v7.4] Hardcode Official templates (#26928)#26956
Merged
jshigetomi merged 2 commits intoPowerShell:release/v7.4from Mar 9, 2026
Merged
[release/v7.4] Hardcode Official templates (#26928)#26956jshigetomi merged 2 commits intoPowerShell:release/v7.4from
jshigetomi merged 2 commits intoPowerShell:release/v7.4from
Conversation
jshigetomi
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.4 of the “Hardcode Official templates” change set, removing the queue-time OfficialBuild toggle and making the affected ADO pipelines always use OneBranch Official templates/settings.
Changes:
- Removed
OfficialBuildparameter usage and conditional template selection in multiple official pipelines. - Hardcoded pipeline naming and environment settings to the official/production values.
- Updated
extends.templatereferences to always use OneBranch Official governed templates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/PowerShell-vPack-Official.yml | Removes OfficialBuild parameter usage; hardcodes official template and build name. |
| .pipelines/PowerShell-Release-Official.yml | Removes OfficialBuild parameter usage; hardcodes production environment and official template. |
| .pipelines/PowerShell-Release-Official-Azure.yml | Removes OfficialBuild parameter usage; hardcodes official template and build name. |
| .pipelines/PowerShell-Packages-Official.yml | Removes OfficialBuild parameter usage; hardcodes official template and passes OfficialBuild: true to MSIX template. |
| .pipelines/PowerShell-Coordinated_Packages-Official.yml | Removes OfficialBuild parameter usage; hardcodes official template and sets ps_official_build to true. |
Comments suppressed due to low confidence (1)
.pipelines/PowerShell-vPack-Official.yml:8
- The
parameters:block is not valid YAML as written: the list items (- name: ...) are not indented underparameters:. This will be parsed as a top-level sequence (and should fail YAML validation). Indent all parameter entries to match the other pipeline files (e.g.,PowerShell-Release-Official.ymlusesparameters:followed by- name: ...).
parameters: # parameters are shown up in ADO UI in a build queue time
- name: 'createVPack'
displayName: 'Create and Submit VPack'
type: boolean
default: true
- name: vPackName
Comment on lines
+78
to
+86
| - ${{ if eq(parameters['FORCE_CODEQL'],'true') }}: | ||
| # Cadence is hours before CodeQL will allow a re-upload of the database | ||
| - name: CodeQL.Cadence | ||
| value: 1 | ||
| - name: CODEQL_ENABLED | ||
| ${{ if or(eq(variables['Build.SourceBranch'], 'refs/heads/master'), eq(parameters['FORCE_CODEQL'],'true')) }}: | ||
| value: true | ||
| ${{ else }}: | ||
| value: false |
There was a problem hiding this comment.
parameters['FORCE_CODEQL'] is referenced in the variables block (for CodeQL.Cadence and CODEQL_ENABLED), but this pipeline does not declare a FORCE_CODEQL parameter in the parameters: section. This will fail template expansion/validation at queue time. Add a FORCE_CODEQL parameter (consistent with other pipelines that use this pattern) or remove/replace these expressions with an existing parameter/variable.
daxian-dbw
approved these changes
Mar 9, 2026
jshigetomi
added a commit
to jshigetomi/PowerShell
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26928 to release/v7.4
Triggered by @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Risk
REQUIRED: Check exactly one box.