[style] Remove local figsize adjustments from all lecture files#574
Merged
[style] Remove local figsize adjustments from all lecture files#574
Conversation
Co-authored-by: mmcky <[email protected]>
Copilot
AI
changed the title
[WIP] [style] Sanitise lectures for figsize and adjust config via myst-nb
[style] Remove local figsize adjustments from all lecture files
Aug 28, 2025
Contributor
|
I have done a visual check of many of these lectures -- I think this change will not have a large impact on fig sizes and I will mention this to the reviewing team to keep an eye out for fig size issues should they come across them when reading a lecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sanitizes all lecture files by removing local matplotlib figsize adjustments as requested in the style cleanup issue.
Changes Made
plt.rcParams["figure.figsize"]from 28 lecture files: All instances of local figsize configuration have been eliminated from the codebaseFiles Modified
All 28 files that contained local figsize settings have been updated:
Impact on Figure Rendering
Figures will now use matplotlib's default size (6.4 × 4.8 inches) instead of the previously configured (11 × 5 inches). The notebooks continue to execute successfully and generate figures as expected.
Testing
grep -r "rcParams.*figsize" lectures/returns 0 results)aiyagari.mdandlinear_algebra.md- both build successfullyNote: Global figsize configuration via myst-nb 1.3.0 configuration was researched but is not readily available in the current version. Figures will use matplotlib defaults unless individually specified.
Fixes #573.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
intro.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -W --keep-going --builder html(dns block)/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/intro.md --path-output ./ -W --keep-going --builder html(dns block)/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/aiyagari.md --path-output ./ -W --keep-going --builder html(dns block)python-advanced.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures --path-output ./ -W --keep-going --builder html(dns block)/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/aiyagari.md --path-output ./ -W --keep-going --builder html(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.