Skip to content

Swift 2.2 and Xcode 7.3#504

Merged
modocache merged 3 commits intoQuick:masterfrom
phatblat:pr/swift2.2
Mar 24, 2016
Merged

Swift 2.2 and Xcode 7.3#504
modocache merged 3 commits intoQuick:masterfrom
phatblat:pr/swift2.2

Conversation

@phatblat
Copy link
Member

@phatblat phatblat commented Mar 24, 2016

General changes to get Quick to build on Xcode 7.3 without warnings.

  • Replace deprecated __FILE__ and __LINE__ with #file and #line, respectively

⚠️ These changes require Xcode 7.3 and Swift 2.2 or better.

I didn't update the Nimble submodule yet, but can once Quick/Nimble#269 is merged.

@phatblat phatblat mentioned this pull request Mar 24, 2016
Closed
@modocache
Copy link
Member

modocache commented Mar 24, 2016

Oh wow, thanks!! I'll merge as soon as CI is green.

@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

😕 Not sure why the builds failed.

The Travis build just cut off because the log was so long:

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

The Circle build looked fine but then there's an assertion failure in DVTNSBundleAdditions.m and a big stack trace.

✓ Touch Quick-iOSTests.xctest (6 ms)

     0 errored, 2 warning (6348 ms)



 [Info] Collecting info for testables...2016-03-23 18:28:46.899 xctool[1601:9663]  DVTAssertions: ASSERTION FAILURE in /Library/Caches/com.apple.xbs/Sources/DVTFrameworks/DVTFrameworks-10174/DVTFoundation/FoundationClassCategories/DVTNSBundleAdditions.m:24
Details:  Assertion failed: [NSThread isMainThread]
Function: NSBundle *_DVTFoundationBundle()
Thread:   <NSThread: 0x7f94da721e20>{number = 2, name = (null)}
Hints: None
Backtrace:
 0   -[DVTAssertionHandler handleFailureInFunction:fileName:lineNumber:assertionSignature:messageFormat:arguments:] (in DVTFoundation)
 1   _DVTAssertionHandler (in DVTFoundation)
 2   _DVTAssertionFailureHandler (in DVTFoundation)
 3   _DVTAssertionFailureHandler (in DVTFoundation)
 4   _DVTFoundationBundle (in DVTFoundation)
 5   -[DVTDeveloperPaths _developerFolderPath] (in DVTFoundation)
 6   -[DVTDeveloperPaths init] (in DVTFoundation)
 7   __33+[DVTDeveloperPaths defaultPaths]_block_invoke (in DVTFoundation)
 8   _dispatch_client_callout (in libdispatch.dylib)
 9   dispatch_once_f (in libdispatch.dylib)
10   +[DVTDeveloperPaths defaultPaths] (in DVTFoundation)
11   __60+[SimServiceContext(DVTAdditions) dvt_sharedServiceContext:]_block_invoke (in DVTiPhoneSimulatorRemoteClient)
12   _dispatch_client_callout (in libdispatch.dylib)
13   dispatch_once_f (in libdispatch.dylib)
14   +[SimServiceContext(DVTAdditions) dvt_sharedServiceContext:] (in DVTiPhoneSimulatorRemoteClient)
15   __41+[DTiPhoneSimulatorSystemRoot initialize]_block_invoke (in DVTiPhoneSimulatorRemoteClient)
16   _dispatch_client_callout (in libdispatch.dylib)
17   dispatch_once_f (in libdispatch.dylib)
18   +[DTiPhoneSimulatorSystemRoot initialize] (in DVTiPhoneSimulatorRemoteClient)
19   _class_initialize (in libobjc.A.dylib)
20   lookUpImpOrForward (in libobjc.A.dylib)
21   objc_msgSend (in libobjc.A.dylib)
22   +[SimulatorInfo _systemRootWithSDKVersion:] (in xctool)
23   -[SimulatorInfo systemRootForSimulatedSdk] (in xctool)
24   -[SimulatorInfo simulatedRuntime] (in xctool)
25   -[SimulatorInfo simulatedDevice] (in xctool)
26   CreateTaskForSimulatorExecutable (in xctool)
27   -[OCUnitIOSLogicTestQueryRunner createTaskForQuery] (in xctool)
28   -[OCUnitTestQueryRunner runQueryWithError:] (in xctool)
29   +[TestableExecutionInfo queryTestCasesWithSimulatorInfo:error:] (in xctool)
30   +[TestableExecutionInfo infoForTestable:buildSettings:simulatorInfo:] (in xctool)
31   __56-[RunTestsAction runTestables:options:xcodeSubjectInfo:]_block_invoke (in xctool)
32   _dispatch_call_block_and_release (in libdispatch.dylib)
33   _dispatch_client_callout (in libdispatch.dylib)
34   _dispatch_queue_drain (in libdispatch.dylib)
35   _dispatch_queue_invoke (in libdispatch.dylib)
36   _dispatch_root_queue_drain (in libdispatch.dylib)
37   _dispatch_worker_thread3 (in libdispatch.dylib)
38   _pthread_wqthread (in libsystem_pthread.dylib)
39   start_wqthread (in libsystem_pthread.dylib)
rake aborted!
RAKE TASK FAILED: xctool -workspace Quick.xcworkspace -scheme Quick-iOS -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 6' clean test

/Users/distiller/Quick/Rakefile:2:in `run'
/Users/distiller/Quick/Rakefile:26:in `block (3 levels) in <top (required)>'
Tasks: TOP => test:xctool:ios

(See full trace by running task with --trace) rake test:xctool:ios returned exit code 1

@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

Narrowed the issue down to the test:xctool:ios rake task. The test:ios task succeeds so this might be an issue with xctool.

@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

Looks like the issue was identified in facebookarchive/xctool#666 (👹) and has been fixed in master, but there hasn't been a release with the fix yet.

@phatblat
TEMP: install xctool --HEAD
0f68052 
Testing to see if >0.2.8 fixes build issues with Xcode 7.3
facebookarchive/xctool#666
@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

xctool 0.2.9 will resolve this build issue.

@modocache
Copy link
Member

modocache commented Mar 24, 2016

Ah, xctool, my old friend. Thanks for debugging this!! I'll merge once the CI job is done. 🙇

@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

Sure thing. Are you OK with leaving xctool at --HEAD for now?

@modocache
Copy link
Member

modocache commented Mar 24, 2016

I don't mind. 💯

@phatblat phatblat mentioned this pull request Mar 24, 2016
Closed
@phatblat
Copy link
Member Author

phatblat commented Mar 24, 2016

Circle is green but travis is failing because the log is exceeding 4MB due to all the deprecation warnings coming from Nimble. I think this issue will go away once Quick/Nimble#269 is accepted.

@modocache
Copy link
Member

modocache commented Mar 24, 2016

Wow, Travis marks long log files as failures:

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

Strange! Yeah, let's get this and Nimble merged ASAP!

@modocache modocache merged commit b5c8b99 into Quick:master Mar 24, 2016
@phatblat phatblat deleted the pr/swift2.2 branch March 24, 2016 02:38
@phatblat phatblat mentioned this pull request Mar 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phatblat @modocache