[4.3] Fixed occlusion culling buffer getting overwritten in larger scenes#978
Merged
Spartan322 merged 1 commit intoRedot-Engine:4.3from Mar 6, 2025
Merged
Conversation
(cherry picked from commit 329d25b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 329d25b)
On subsequent calls to
_transform_vertices_range()(wherep_fromwould have been adjusted) it would still start writing to the same index in ofxformed_verticeseffectively overwriting and corrupting vertex data previously written.The correct implementation is to offset
p_writewith 3*p_from.I tested using occlusion_culling_mesh_lod for both double and float builds.
Before:
After:
